Change truthy lint criticality and fixes errors, refs #33952

.devcontainer/Dockerfile

@@ -31,9 +31,11 @@ RUN \
         wheel \
         && \
     # import hashicorp gpg key
-    sudo gpg --keyserver hkp://eu.pool.sks-keyservers.net --recv-key 51852D87348FFC4C && \
+    #sudo gpg --keyserver hkp://eu.pool.sks-keyservers.net --recv-key 51852D87348FFC4C && \
+    sudo gpg --keyserver hkp://eu.pool.sks-keyservers.net --recv-key 72D7468F && \
     :
 
+
 ARG PACKER_VERSION=1.5.5
 RUN \
     # packer
@@ -46,6 +48,7 @@ RUN \
     sudo rm -f packer_${PACKER_VERSION}* && \
     :
 
+
 ARG GO_VERSION=1.14.1
 RUN \
     # golang

.yamllint

@@ -20,7 +20,7 @@ rules:
     max-spaces-inside: 1
     level: error
   truthy:
-    level: warning
+    level: error
   line-length: disable
   indentation:
     spaces: consistent

ansible/playbooks/ovh/provisioning.yml

@@ -2,17 +2,17 @@
 - name: SET VARIABLES WHEN PROVISIONING
   hosts: localhost
   tags: always
-  gather_facts: no
+  gather_facts: false
   run_once: true
   tasks:
     - name: not provisioning
       set_fact:
         provisioning: false
-      delegate_facts: yes
+      delegate_facts: true
     - name: enable provisioning
       set_fact:
         provisioning: true
-      delegate_facts: yes
+      delegate_facts: true
       when: ('force-delete' not in ansible_run_tags)
 
 - name: OVH CLOUD PROVISIONING
@@ -39,7 +39,7 @@
         name: "{{ item.metadata.hostname }}"
         ansible_host: "{{ item.accessIPv4 }}"
         ansible_user: debian
-        ansible_become: yes
+        ansible_become: true
       loop: "{{ current_servers }}"
 
     - name: launch a compute instance for non existant hosts
@@ -69,7 +69,7 @@
         name: "{{ item.metadata.hostname }}"
         ansible_host: "{{ item.accessIPv4 }}"
         ansible_user: debian
-        ansible_become: yes
+        ansible_become: true
       loop: "{{ openstack_servers | json_query('results[*].openstack') }}"
 
 ...

ansible/playbooks/site_ovh.yml

@@ -4,7 +4,7 @@
 - name: NFS mount provisioning
   hosts: mediaserver
   tags: always
-  gather_facts: no
+  gather_facts: false
   vars:
     ovh_prefix: cloud
   tasks:
@@ -38,7 +38,7 @@
       apt:
         name: nfs-common
         state: latest
-        update_cache: yes
+        update_cache: true
       when:
         - hostvars.localhost.provisioning == true
 
@@ -47,7 +47,7 @@
         fstype: nfs
         opts: "{{ item.mount_options }}"
         dump: "0"
-        passno: "0"
+        passfalse: "0"
         state: mounted
         src: "{{ item.mount_ip }}:{{ item.name }}/{{ item.partition }}"
         path: "{{ item.mount_endpoint }}"
@@ -62,7 +62,7 @@
 
 - name: Verify mediaserver installation then add server to load balancer
   hosts: mediaserver
-  gather_facts: no
+  gather_facts: false
   vars:
     ovh_prefix: cloud
   tasks:
@@ -80,7 +80,7 @@
         address: "{{ hostvars[inventory_hostname].ansible_host }}"
         port: 443
         status: active
-        ssl: yes
+        ssl: true
         farmtype: http
         endpoint: "{{ ovh_endpoint }}"
         application_key: "{{ ovh_application_key }}"
@@ -96,7 +96,7 @@
 
 - name: Verify wowza installation then add server to load balancer
   hosts: wowza
-  gather_facts: no
+  gather_facts: false
   vars:
     ovh_prefix: cloud
   tasks:
@@ -113,7 +113,7 @@
         address: "{{ hostvars[inventory_hostname].ansible_host }}"
         port: 1935
         status: active
-        ssl: no
+        ssl: false
         farmtype: tcp
         endpoint: "{{ ovh_endpoint }}"
         application_key: "{{ ovh_application_key }}"
@@ -132,7 +132,7 @@
 
 - name: OVH CLOUD DEPROVISIONING WOWZA
   hosts: wowza
-  gather_facts: no
+  gather_facts: false
   tags: [ 'never', 'force-delete' ]
   tasks:
     - name: remove ip on load balancer (tcp 1935)
@@ -143,7 +143,7 @@
         address: "{{ hostvars[inventory_hostname].ansible_host }}"
         port: 1935
         status: active
-        ssl: yes
+        ssl: true
         farmtype: tcp
         endpoint: "{{ ovh_endpoint }}"
         application_key: "{{ ovh_application_key }}"
@@ -157,7 +157,7 @@
 
 - name: OVH CLOUD DEPROVISIONING MEDIASERVER
   hosts: mediaserver
-  gather_facts: no
+  gather_facts: false
   tags: [ 'never', 'force-delete' ]
   tasks:
     - name: remove ip on load balancer (http 443)
@@ -168,7 +168,7 @@
         address: "{{ hostvars[inventory_hostname].ansible_host }}"
         port: 443
         status: active
-        ssl: yes
+        ssl: true
         farmtype: http
         endpoint: "{{ ovh_endpoint }}"
         application_key: "{{ ovh_application_key }}"
@@ -196,7 +196,7 @@
 
 - name: REFRESH LOAD BALANCER
   hosts: localhost
-  gather_facts: no
+  gather_facts: false
   tags: always
   tasks:
     - name: refresh loadbalancer state
@@ -206,9 +206,9 @@
         application_key: "{{ ovh_application_key }}"
         application_secret: "{{ ovh_application_secret }}"
         consumer_key: "{{ ovh_consumer_key }}"
-        refresh: yes
+        refresh: true
       delegate_to: localhost
-      run_once: yes
+      run_once: true
 
 - name: COMPLETE TEST
   hosts: mediaserver