Fix various lint

ansible/molecule/mediaserver-ha/converge.yml

@@ -26,7 +26,7 @@
         path: /etc/hosts.aliases
         line: "{{ hostvars[item]['ansible_default_ipv4']['address'] }} {{ item }}"
         backup: true
-        create: yes
+        create: true
       tags: always
       when: not etc_hosts_debian.stat.exists
     - name: add all hosts to hostfile
@@ -56,5 +56,4 @@
 
 - import_playbook: ../../playbooks/site.yml
 
-
 ...

ansible/molecule/pgsql-ha/molecule.yml

@@ -53,6 +53,6 @@ provisioner:
     side_effect: side_effect.yml
 verifier:
   name: testinfra
-  # options:
-    # verbose: true
-    # s: true
+#  options:
+#    verbose: true
+#    s: true

ansible/roles/bench-server/tasks/main.yml

@@ -4,7 +4,7 @@
   apt:
     force_apt_get: true
     install_recommends: false
-    update_cache: yes
+    update_cache: true
     name: "{{ bench_server_packages }}"
     state: latest
   register: apt_status
@@ -49,14 +49,14 @@
     repo: "{{ bench_stream_repo }}"
     version: stable
     dest: /usr/share/ms-testing-suite
-    update: yes
-    force: yes
+    update: true
+    force: true
 
 - name: copy configuration for testing tools
   copy:
     src: /etc/mediaserver/bench-streaming.conf
     dest: /usr/share/ms-testing-suite/config.json
-    remote_src: yes
+    remote_src: true
 
 - name: add docker key
   when:
@@ -73,7 +73,7 @@
   apt_repository:
     repo: "deb https://download.docker.com/linux/debian buster stable"
     state: present
-    update_cache: yes
+    update_cache: true
 
 - name: install docker
   when:
@@ -82,7 +82,7 @@
   apt:
     force_apt_get: true
     install_recommends: false
-    update_cache: yes
+    update_cache: true
     name: docker-ce
     state: latest
   register: apt_status
@@ -96,6 +96,6 @@
   command:
     cmd: make build_docker_img
     chdir: /usr/share/ms-testing-suite
-  run_once: yes
+  run_once: true
 
 ...

ansible/roles/bench-worker/tasks/main.yml

@@ -4,7 +4,7 @@
   apt:
     force_apt_get: true
     install_recommends: false
-    update_cache: yes
+    update_cache: true
     name: "{{ bench_worker_packages }}"
     state: latest
   register: apt_status

ansible/roles/docker/tasks/main.yml

@@ -27,7 +27,7 @@
   apt_repository:
     repo: deb [arch=amd64] https://download.docker.com/linux/{{ ansible_distribution | lower }} {{ ansible_distribution_release | lower }} stable
     state: present
-    update_cache: yes
+    update_cache: true
 
 - name: install docker
   when:
@@ -35,7 +35,7 @@
   apt:
     name: docker-ce
     state: latest
-    update_cache: yes
+    update_cache: true
   register: apt_status
   retries: 60
   until: apt_status is success or ('Failed to lock apt for exclusive operation' not in apt_status.msg and '/var/lib/dpkg/lock' not in apt_status.msg)
@@ -54,7 +54,7 @@
   apt:
     name: python3-docker
     state: latest
-    update_cache: yes
+    update_cache: true
   register: apt_status
   retries: 60
   until: apt_status is success or ('Failed to lock apt for exclusive operation' not in apt_status.msg and '/var/lib/dpkg/lock' not in apt_status.msg)

ansible/roles/ferm-install/tasks/main.yml

@@ -20,7 +20,7 @@
   systemd:
     name: ferm
     enabled: true
-    masked: no
+    masked: false
     state: started
 
 ...

ansible/roles/mediaserver/defaults/main.yml

@@ -44,7 +44,7 @@ server_ferm_input_rules:
 server_ferm_output_rules: []
 server_ferm_global_settings:
 
-real_ip_from: "" # default for OVH is 10.108.0.0/14
+real_ip_from: ""    # default for OVH is 10.108.0.0/14
 
 
 ...

ansible/roles/mediaserver/tasks/main.yml

@@ -95,7 +95,7 @@
   throttle: 1
 
 - name: synchronize configuration between servers
-  ignore_errors: yes
+  ignore_errors: true
   when:
     - groups['mediaserver'] | length > 1
     - inventory_hostname != groups['mediaserver'][0]
@@ -109,11 +109,11 @@
     src: "{{ item }}"
     dest: "{{ item }}"
     mode: push
-    copy_links: yes
-    delete: yes
-    recursive: yes
-    set_remote_user: no
-    existing_only: yes
+    copy_links: true
+    delete: true
+    recursive: true
+    set_remote_user: false
+    existing_only: true
   notify:
     - restart mediaserver
     - restart nginx
@@ -122,7 +122,7 @@
   tags: mediaserver-synchronize
 
 - name: synchronize letsencrypt configuration between servers
-  ignore_errors: yes
+  ignore_errors: true
   when:
     - groups['mediaserver'] | length > 1
     - inventory_hostname != groups['mediaserver'][0]
@@ -133,11 +133,11 @@
     src: "{{ item }}"
     dest: "{{ item }}"
     mode: push
-    copy_links: yes
-    delete: yes
-    recursive: yes
-    set_remote_user: no
-    existing_only: yes
+    copy_links: true
+    delete: true
+    recursive: true
+    set_remote_user: false
+    existing_only: true
   notify:
     - restart nginx
   delegate_to: "{{ groups['mediaserver'][0] }}"

ansible/roles/metricbeat/tasks/main.yml

@@ -48,7 +48,7 @@
 - name: enable metricbeat client
   systemd:
     name: metricbeat
-    enabled: yes
+    enabled: true
     state: started
 
 ...

ansible/roles/sysconfig/tasks/main.yml

@@ -55,7 +55,7 @@
     dest: /root/.ssh/authorized_keys
     regexp: "^no-port-forwarding,(.+) ssh-"
     replace: "ssh-"
-  ignore_errors: yes
+  ignore_errors: true
 
 # FIREWALL