Merge branch 't35415-fix-linting' into 'main'

Fix linting, Refs #35415

See merge request sys/ansible-public!12

playbooks/bench.yml

@@ -13,10 +13,12 @@
     - bench-server
   tasks:
     - name: restart bench-server
+      tags:
+        - never
+        - prepare-bench
       service:
         name: bench-server
         state: restarted
-      tags: [ 'never', 'prepare-bench' ]
 
 - name: DEPLOY BENCHMARK WORKERS
   hosts: bench_worker
@@ -25,9 +27,11 @@
     - bench-worker
   tasks:
     - name: restart bench-worker
+      tags:
+        - never
+        - prepare-bench
       service:
         name: bench-worker
         state: restarted
-      tags: [ 'never', 'prepare-bench' ]
 
 ...

requirements.dev.txt

 ansible-lint
 flake8
-git+git://github.com/atmaniak/molecule@e03437923b302fca1bd7b4f6030c6956ad00367a#egg=molecule[docker]
-#molecule[docker]
+#git+git://github.com/atmaniak/molecule@e03437923b302fca1bd7b4f6030c6956ad00367a#egg=molecule[docker]
+molecule[docker]
 pytest-testinfra
 yamllint

roles/mediaimport/tasks/main.yml

@@ -86,7 +86,7 @@
     path: /etc/ssl/{{ ansible_fqdn }}/key.pem
 
 - name: generate an csr
-  when: mediaimport_privkey is changed
+  when: mediaimport_privkey is changed  # noqa no-handler
   register: mediaimport_csr
   openssl_csr:
     path: /etc/ssl/{{ ansible_fqdn }}/csr.pem
@@ -94,7 +94,7 @@
     common_name: "{{ ansible_fqdn }}"
 
 - name: generate a self-signed certificate
-  when: mediaimport_csr is changed
+  when: mediaimport_csr is changed  # noqa no-handler
   register: mediaimport_cert
   openssl_certificate:
     path: /etc/ssl/{{ ansible_fqdn }}/cert.pem
@@ -103,7 +103,7 @@
     provider: selfsigned
 
 - name: concatenate key and certificate
-  when: mediaimport_cert is changed
+  when: mediaimport_cert is changed  # noqa no-handler
   notify: restart pure-ftpd
   shell: >
     cat /etc/ssl/{{ ansible_fqdn }}/key.pem /etc/ssl/{{ ansible_fqdn }}/cert.pem > /etc/ssl/private/pure-ftpd.pem;

roles/mediaserver/tasks/main.yml

@@ -92,7 +92,7 @@
   throttle: 1
 
 - name: synchronize configuration between servers
-  ignore_errors: true
+  ignore_errors: true  # noqa ignore-errors
   when:
     - groups['mediaserver'] | length > 1
     - inventory_hostname != groups['mediaserver'][0]
@@ -119,7 +119,7 @@
   tags: mediaserver-synchronize
 
 - name: synchronize letsencrypt configuration between servers
-  ignore_errors: true
+  ignore_errors: true  # noqa ignore-errors
   when:
     - groups['mediaserver'] | length > 1
     - inventory_hostname != groups['mediaserver'][0]