Merge branch 't36656-certbot-hook' into 'main'

Remove useless nginx test in post-hook | refs #36656

See merge request sys/ansible-public!27

.gitlab-ci.yml

 ---
-
 checkpf:
   # https://docs.gitlab.com/ee/ci/pipelines/multi_project_pipelines.html
   trigger:
@@ -7,21 +6,21 @@ checkpf:
     strategy: depend
   # Sends the current branch to the ubicast-environment triggered pipeline as a variable
   variables:
-    ANSIBLE_BRANCH: "$CI_COMMIT_BRANCH"
-    DEPLOY_STD: "$DEPLOY_STD"
-    DEPLOY_HA: "$DEPLOY_HA"
-    DESTROY_STD: "$DESTROY_STD"
-    DESTROY_HA: "$DESTROY_HA"
-    LINT: "$LINT"
+    ANSIBLE_BRANCH: $CI_COMMIT_BRANCH
+    DEPLOY_STD: $DEPLOY_STD
+    DEPLOY_HA: $DEPLOY_HA
+    DESTROY_STD: $DESTROY_STD
+    DESTROY_HA: $DESTROY_HA
+    LINT: $LINT
   # Register the job in a resource group to prevent having multiple running pipelines in parallel
   resource_group: deployment
   rules:
     # Only triggers the pipeline if it's launched manually from the GitLab webinterface
-    - if: '$CI_PIPELINE_SOURCE == "web"'
+    - if: $CI_PIPELINE_SOURCE == "web"
     # Only triggers the pipeline if it's launched by a scheduled job
-    - if: '$CI_PIPELINE_SOURCE == "schedule"'
+    - if: $CI_PIPELINE_SOURCE == "schedule"
     # Only if push on the main branch
-    - if: '$CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == "main"'
+    - if: $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == "main"
 
 lint:
   # https://docs.gitlab.com/ee/ci/pipelines/multi_project_pipelines.html
@@ -30,12 +29,10 @@ lint:
     strategy: depend
   # Sends the current branch to the ubicast-environment triggered pipeline as a variable
   variables:
-    ANSIBLE_BRANCH: "$CI_COMMIT_BRANCH"
+    ANSIBLE_BRANCH: $CI_COMMIT_BRANCH
     DEPLOY_STD: "false"
     DEPLOY_HA: "false"
   resource_group: deployment
   rules:
     # Only if push in a branch other than main
-    - if: '$CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH != "main"'
-
-...
+    - if: $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH != "main"

.lint/ansible-lint.conf

@@ -5,9 +5,13 @@ exclude_paths:
   - ${HOME}/.cache/
 
 skip_list:
-  - meta-no-info    # Skip warnings for missing galaxy_info in roles
-  - role-name       # Skip role name pattern verification ("-" should not be used)
-  - package-latest  # Skip warning when package installation state is set to latest
-  - experimental    # Skip all rules tagged as experimental, as schema validation
+  - meta-no-info              # Skip warnings for missing galaxy_info in roles
+  - role-name                 # Skip role name pattern verification ("-" should not be used)
+  - package-latest            # Skip warning when package installation state is set to latest
+  - experimental              # Skip all rules tagged as experimental, as schema validation
+  - name[play]                # Skip the rule dictating that all play should have a name
+  - name[casing]              # Skip the rule dictating that all task name should begin with uppercase
+  - template-instead-of-copy  # Skip forcing the use of templates
+  - name[template]            # Skip forcing to use jinja var at the end of a task name
 
 ...

inventories/example-ha/group_vars/all.yml

 ---
-
 # customer name
 customer_short_name: customer
 
@@ -16,7 +15,7 @@ repmgr_primary_node: "{{ hostvars['pg1']['ansible_default_ipv4']['address'] }}"
 # ha proxy configuration
 hap_config_listen:
   - name: pgsql-primary
-    content: |2
+    content: |
       bind localhost:54321
       default-server inter 2s fall 3 rise 2 on-marked-down shutdown-sessions
       option tcp-check
@@ -24,5 +23,3 @@ hap_config_listen:
       maxconn 500
       server pg1 192.168.122.1:5432 maxconn 500 check port 8543
       server pg2 192.168.122.2:5432 maxconn 500 check port 8543 backup
-
-...

inventories/example-ha/host_vars/cs1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mi1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mm1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mo1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/ms1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/ms2.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mv1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mw1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/mw2.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example-ha/host_vars/pg1.yml

 ---
-
 skyreach_system_key: changeme
 
 db_role: primary
 repmgr_node_id: 1
-
-...

inventories/example-ha/host_vars/pg2.yml

 ---
-
 skyreach_system_key: changeme
 
 db_role: standby
 repmgr_node_id: 2
-
-...

inventories/example-ha/host_vars/pg3.yml

 ---
-
 skyreach_system_key: changeme
 
 db_role: witness
 repmgr_node_id: 3
-
-...

inventories/example-ha/host_vars/ws1.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example/group_vars/all.yml

 ---
-
 # customer name
 customer_short_name: customer
 
@@ -8,5 +7,3 @@ letsencrypt_enabled: false
 
 # update conf.sh
 conf_update: false
-
-...

inventories/example/host_vars/mymediaserver.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example/host_vars/mymediavault.yml

 ---
-
 skyreach_system_key: changeme
-
-...

inventories/example/host_vars/mymediaworker.yml

 ---
-
 skyreach_system_key: changeme
-
-...