Skip to content
Snippets Groups Projects
  1. Apr 12, 2022
  2. Mar 23, 2022
  3. Mar 22, 2022
  4. Mar 18, 2022
  5. Mar 17, 2022
  6. Mar 16, 2022
    • Simon McVittie's avatar
      Merge branch 'backport-2554-timezone-offset-glib-2-70' into 'glib-2-70' · 176df2ab
      Simon McVittie authored
      Backport !2554 “gtimezone: Fix assertion failure when called with a huge offset” to glib-2-70
      
      See merge request GNOME/glib!2555
      176df2ab
    • Philip Withnall's avatar
      gtimezone: Fix assertion failure when called with a huge offset · 0b633127
      Philip Withnall authored
      
      This looks like a regression from commit 3356934d, but prior to that
      commit there was always an assertion failure when calling
      `g_time_zone_new_offset()` with an offset which is too large (such as 44
      hours), ever since the function was added in commit cf24867b.
      
      It would be ideal if we could return a `NULL` timezone to indicate the
      error, but that’s not part of the API for `g_time_zone_new_offset()`, so
      we have to go with the dated and not-ideal approach of returning the UTC
      timezone and letting the caller figure it out.
      
      Another potential approach would be to reduce the `offset` modulo 24
      hours. This makes the error less easily detectable than if returning
      UTC, though, and still returns an invalid result: `+44:00` is not the
      same timezone as `+20:00` (it’s one day further ahead).
      
      Add a unit test.
      
      Signed-off-by: default avatarPhilip Withnall <pwithnall@endlessos.org>
      
      Fixes: #2620
      0b633127
    • Simon McVittie's avatar
      Merge branch '2620-timezone-offset' into 'main' · 2fd43828
      Simon McVittie authored
      gtimezone: Fix assertion failure when called with a huge offset
      
      Closes #2620
      
      See merge request GNOME/glib!2554
      2fd43828
    • Philip Withnall's avatar
      gtimezone: Fix assertion failure when called with a huge offset · 7ab9359a
      Philip Withnall authored
      
      This looks like a regression from commit 3356934d, but prior to that
      commit there was always an assertion failure when calling
      `g_time_zone_new_offset()` with an offset which is too large (such as 44
      hours), ever since the function was added in commit cf24867b.
      
      It would be ideal if we could return a `NULL` timezone to indicate the
      error, but that’s not part of the API for `g_time_zone_new_offset()`, so
      we have to go with the dated and not-ideal approach of returning the UTC
      timezone and letting the caller figure it out.
      
      Another potential approach would be to reduce the `offset` modulo 24
      hours. This makes the error less easily detectable than if returning
      UTC, though, and still returns an invalid result: `+44:00` is not the
      same timezone as `+20:00` (it’s one day further ahead).
      
      Add a unit test.
      
      Signed-off-by: default avatarPhilip Withnall <pwithnall@endlessos.org>
      
      Fixes: #2620
      7ab9359a
    • Philip Withnall's avatar
      Merge branch 'mcatanzaro/typo' into 'main' · 7f0f8735
      Philip Withnall authored
      gtlsconnection: fix typo in docs
      
      See merge request GNOME/glib!2552
      7f0f8735
    • Michael Catanzaro's avatar
      gtlsconnection: fix typo in docs · 69a1867d
      Michael Catanzaro authored
      Grrr, copy/paste error detected.
      69a1867d
    • Philip Withnall's avatar
      Merge branch 'wip/pwithnall/more-test-fixes' into 'main' · b86750cb
      Philip Withnall authored
      tests: More flaky test fixes to converter-stream and test-printf
      
      See merge request GNOME/glib!2551
      b86750cb
  7. Mar 14, 2022
  8. Mar 12, 2022
Loading