Do not raise error when ubicast repository is not present

tests/scripts/test_apt.py

@@ -116,55 +116,51 @@ def main():
         or apt.is_installed("celerity-server")
         or apt.is_installed("celerity-utils")
         or apt.is_installed("celerity-workers")
-        # older versions
-        or apt.is_installed("python3-mediaserver")
-        or apt.is_installed("python3-mediaserver-monitor")
-        or apt.is_installed("campus-manager")
         else False
     )
     if ubicast_repo and ubicast_package:
         lg.success("ubicast repository present")
     elif not ubicast_repo and ubicast_package:
-        lg.error("ubicast repository missing")
-        errors += 1
+        lg.warning("ubicast repository missing")
+        warnings += 1
     elif not ubicast_repo and not ubicast_package:
         lg.info("no ubicast repository and service installed")
-        return 2
     else:
         lg.info("no ubicast service installed")
 
-    # check ubicast repository url
-    regexp_repo = (
-        r"^deb (http[s]?://[A-Za-z0-9\.\-\_]+) packaging/apt/([A-Za-z0-9\.\-\_]+)/$"
-    )
-    repo_url_match = line_in_file(regexp_repo, "/etc/apt/sources.list.d/skyreach.list")
-    if repo_url_match:
-        url, apt_token = repo_url_match.groups()
-        lg.success("url: {}, token: {}[...]".format(url, apt_token[:8]))
-    else:
-        url, apt_token = None, None
-        lg.error("incorrect ubicast repository url or token")
-        errors += 1
-
-    # check server avalability
-    if url:
-        server_response = requests.get(url, verify=False)
-        if server_response.ok:
-            lg.success("request to {} succeeded".format(url))
+    if ubicast_repo:
+        # check ubicast repository url
+        regexp_repo = (
+            r"^deb (http[s]?://[A-Za-z0-9\.\-\_]+) packaging/apt/([A-Za-z0-9\.\-\_]+)/$"
+        )
+        repo_url_match = line_in_file(regexp_repo, "/etc/apt/sources.list.d/skyreach.list")
+        if repo_url_match:
+            url, apt_token = repo_url_match.groups()
+            lg.success("url: {}, token: {}[...]".format(url, apt_token[:8]))
         else:
-            lg.error("request to {} failed: {}".format(url, server_response.text))
+            url, apt_token = None, None
+            lg.error("incorrect ubicast repository url or token")
             errors += 1
 
-    # check repository avalability
-    if url and apt_token:
-        apt_url = "{}/packaging/apt/{}/Packages".format(url, apt_token)
-        repo_response = requests.get(apt_url, verify=False)
-        apt_url = "{}/packaging/apt/{}[...]/Packages".format(url, apt_token[:8])
-        if repo_response.ok:
-            lg.success("request to {} succeeded".format(apt_url))
-        else:
-            lg.error("request to {} failed: {}".format(apt_url, repo_response.text))
-            errors += 1
+        # check server avalability
+        if url:
+            server_response = requests.get(url, verify=False)
+            if server_response.ok:
+                lg.success("request to {} succeeded".format(url))
+            else:
+                lg.error("request to {} failed: {}".format(url, server_response.text))
+                errors += 1
+
+        # check repository avalability
+        if url and apt_token:
+            apt_url = "{}/packaging/apt/{}/Packages".format(url, apt_token)
+            repo_response = requests.get(apt_url, verify=False)
+            apt_url = "{}/packaging/apt/{}[...]/Packages".format(url, apt_token[:8])
+            if repo_response.ok:
+                lg.success("request to {} succeeded".format(apt_url))
+            else:
+                lg.error("request to {} failed: {}".format(apt_url, repo_response.text))
+                errors += 1
 
     if errors:
         return 1