diff --git a/tests/test_dns_records.py b/tests/test_dns_records.py index ad8358c77b41ae69098a9c67ba311466cc568e8c..5107e3ce548c98585149002281ea44444d276d17 100755 --- a/tests/test_dns_records.py +++ b/tests/test_dns_records.py @@ -18,13 +18,14 @@ from envsetup import utils as u # noqa: E402 def get_dns_servers() -> set: servers = list() + ip_pattern = re.compile(r"^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$") if subprocess.getstatusoutput("command -v nmcli")[0] == 0: # network-manager _, output = subprocess.getstatusoutput( "nmcli -f all device show | grep IP4.DNS | awk '{ print $2 }'" ) - servers = [l for l in output.split("\n") if l] + servers = [l for l in output.split("\n") if ip_pattern.match(l)] if not len(servers): # resolvconf @@ -38,7 +39,6 @@ def get_dns_servers() -> set: _, output = subprocess.getstatusoutput("systemd-resolve --status") lines = [l.strip() for l in output.split("\n")] dns_line = False - ip_pattern = re.compile("\d+\.\d+\.\d+\.\d+") for line in lines: if line.startswith("DNS Servers:"): dns_line = True